Fix aggregate metrics returning 0/0.0 instead of None for empty result sets#2037
Open
dudanogueira wants to merge 2 commits into
Open
Fix aggregate metrics returning 0/0.0 instead of None for empty result sets#2037dudanogueira wants to merge 2 commits into
dudanogueira wants to merge 2 commits into
Conversation
…t sets - Fixed __parse_property_grpc() to check HasField() before accessing optional protobuf scalars - Integer/Number aggregates now correctly return None for unset metrics (maximum, mean, median, minimum, mode, sum_) - Date aggregates now correctly return None for unset metrics (maximum, median, minimum, mode) - Boolean aggregates now correctly return None for unset metrics (percentage_false, percentage_true, total_false, total_true) - Added integration test to verify None values for empty aggregate results - Aligns gRPC behavior with GraphQL API behavior Fixes weaviate#2036
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug where empty-set aggregate metrics over gRPC returned scalar defaults (0/0.0) instead of None, by gating each optional field read with HasField(). Aligns gRPC behavior with the GraphQL API.
Changes:
- Use
HasField()checks for optional integer/number/boolean/date aggregate metric fields in__parse_property_grpc. - Add an integration test confirming
Nonevalues for empty aggregate result sets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| weaviate/collections/aggregations/base_executor.py | Guard optional protobuf scalar reads with HasField() to preserve unset/None semantics. |
| integration/test_collection_aggregate.py | New integration test verifying integer/number aggregates return None for empty filter results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix aggregate metrics returning 0/0.0 instead of None for empty result sets
Fixes #2036